search

gitkraken / vscode-gitlens

Supercharge Git inside VS Code and unlock untapped knowledge within each repository — Visualize code authorship at a glance via Git blame annotations and CodeLens, seamlessly navigate and explore Git repositories, gain valuable insights via rich visualizations and powerful comparison commands, and so much more
http://gitkraken.com/gitlens
Other
8.94k stars 1.27k forks source link

Enable login for VSCodium #1430

Open pmahend1 opened 3 years ago

pmahend1 commented 3 years ago

Since this extension is available for VSCodium as well, please enable Github authentication authorization

Probably needs slight modifications in src/github/github.ts

pmahend1 commented 3 years ago

Similar to https://github.com/microsoft/vscode-pull-request-github/issues/2576

eamodio commented 3 years ago

While this isn't something that I will likely add myself, if the community wants to champion it, and provide a PR (after discussions) I'm certainly open to it — depending, of course, on the complexity and scope of the changes involved.

pmahend1 commented 3 years ago

@eamodio I will take it up if you can register an OAuthapp and/or GitHub app for the repository and provide me the same , that would be great! I don't know if its a good idea to do that on a forked repository

eamodio commented 3 years ago

Thinking about this more -- I really don't want to maintain a separate auth provider for something like this. IMO, VSCodium should just implement a GitHub auth provider extension (like VS Code has built in), and then GitLens and any other extensions could access it without any changes.

pmahend1 commented 3 years ago

@eamodio is it possible to add GitLens as a GitHub app and then use multiple redirect URLs? That will make it extendable to other open source versions of vs code as well. If the extension is available for other IDEs as well then we can't make use of that built it Auth provider it seems. That will make it extendable to other open source versions of vs code as well.

hashkool commented 3 years ago

@eamodio Are you ok with the proposed direction or do you have other ideas?

I still see this is in limbo and the other pull request still open. Currently VScodium is broken due to this, so would be nice if we can decide on an approach.

calvin-cdev commented 2 years ago

bumping this. I'd love to try out the GitLense+ features and I'm a paying user of GitKraken, but I use VSCodium so the oauth login doesn't work :/

eamodio commented 2 years ago

@calvin-summer I thought I had enabled that, but looked into it and I need to figure out the scheme that vscodium registers for URL callbacks.