Interactive Rebase Editor setting not persisted

gitkraken / vscode-gitlens

Supercharge Git inside VS Code and unlock untapped knowledge within each repository — Visualize code authorship at a glance via Git blame annotations and CodeLens, seamlessly navigate and explore Git repositories, gain valuable insights via rich visualizations and powerful comparison commands, and so much more

http://gitkraken.com/gitlens

Other

8.87k stars 1.23k forks source link

Interactive Rebase Editor setting not persisted #1765

Open winterqt opened 2 years ago

winterqt commented 2 years ago

GitLens Version: v11.7.0
Git Version: v2.34.1
VSCode Version: v1.63.2
OS Version: macOS 12.1

Steps to Reproduce:

Disable the interactive rebase editor
Observe that no setting is written to the selected settings file (either user or workspace)

This does work for other options, such as enabling/disabling the menus.

winterqt commented 2 years ago

For anyone else experiencing this issue, you can add the following to your user or workspace settings:

{
  "workbench.editorAssociations": {
    "git-rebase-todo": "default"
  }
}

This is what RebaseEditorProvider::enabled (and setEnabled) uses to check if the interactive rebase editor should be used.

winterqt commented 2 years ago

This fix does not work as of recent versions of GitLens. (v12.0.0 maybe?)