gitkraken / vscode-gitlens

Supercharge Git inside VS Code and unlock untapped knowledge within each repository — Visualize code authorship at a glance via Git blame annotations and CodeLens, seamlessly navigate and explore Git repositories, gain valuable insights via rich visualizations and powerful comparison commands, and so much more
http://gitkraken.com/gitlens
Other
8.98k stars 1.32k forks source link

The experience of viewing file changes is poor in commit graph #2537

Closed pavlelee closed 1 year ago

pavlelee commented 1 year ago
image

The questions are as follows:

  1. After clicking on commit, the details displayed are very small.
  2. Click on the file to view the difference. The difference page is very small.
  3. To continuously view the changes of different submitted files, you must first unpin

You can refer to the same type plug-in Git Graph

image

Click on the file to view the difference, will be displayed all over the screen.

image
eamodio commented 1 year ago

@pavlelee Thanks for the feedback!

After clicking on commit, the details displayed are very small.

The best option here, is to drag the Commit Details view into its own sidebar or better yet drag it all the way to the right side and drop it into the Secondary Sidebar. We are discussing putting the Commit Details view into its own sidebar by default -- but unfortunately, we can't automatically add it to the Secondary Sidebar (VS Code doesn't allow extensions to place things there by default yet)

Click on the file to view the difference. The difference page is very small.

We are looking at adding some better options here -- how would you want this to work? Would you want the diff to hide the Graph and open the diff in the same group? Or open it below the Graph rather than to the right?

To continuously view the changes of different submitted files, you must first unpin

This should now be resolved in the latest pre-release edition of GitLens and will be coming soon to the stable GitLens release.

You can switch to the pre-release edition of GitLens, by clicking on the "Switch to Pre-Release version of this extension" from the Extensions view.

image

Hope that helps!

pavlelee commented 1 year ago

@eamodio Thanks for the feedback!

The interactive experience of the new version is even worse. First of all, I want to see the commit graph. Content should focus on the whole page, not split right, which will not be the case in the previous version, which is degraded. image

The best option here, is to drag the Commit Details view into its own sidebar or better yet drag it all the way to the right side and drop it into the Secondary Sidebar. We are discussing putting the Commit Details view into its own sidebar by default -- but unfortunately, we can't automatically add it to the Secondary Sidebar (VS Code doesn't allow extensions to place things there by default yet)

The visual experience will be better this way, but the linkage is too poor. Clicking commit will not automatically pop up sidebar, and closing Commit Graph will not close sidebar. image

We are looking at adding some better options here -- how would you want this to work? Would you want the diff to hide the Graph and open the diff in the same group? Or open it below the Graph rather than to the right?

Diff view generally has a lot of content, so it's best to show it on the full page instead of split right. It's more practical.

pavlelee commented 1 year ago

This barely meets my interaction needs. But still doesn't have a smooth experience of Git Graph. image

eamodio commented 1 year ago

FYI, https://github.com/gitkraken/vscode-gitlens/issues/2602 has landed in pre-release which could be a good alternative to help with this.

But the latest pre-release has further improvements as well. We now will open the diffs in the active editor group, rather than in a new group on the side. We will eventually be looking into further possibilities with some new APIs in VS Code.

pavlelee commented 1 year ago

@eamodio "gitlens.graph.layout": "panel" This solution has satisfied the usage habit, and such a fast response speed makes me more confident in the pro version. But the experience of editor is still very poor. image

pavlelee commented 1 year ago

@eamodio I found new bug, it's not work

image
eamodio commented 1 year ago

@pavlelee Doh, that's good catch -- that is fixed by https://github.com/gitkraken/vscode-gitlens/commit/2aace4b57293d09b149782ca162b7130a7d48737. Will be out in tomorrow's pre-release.

Can you provide more actionable feedback with the editor layout to see what we can improve? While we may have limited options to the control VS Code allows extensions, we definitely want to see what we can still do.

pavlelee commented 1 year ago

@eamodio v2023.4.505 version already satisfy the usage habit In the editor layout, But the commit detail will not be closed when the graph is close. and the experience is poor if not drag it to the right side, this had better be used out of the box.

image image
eamodio commented 1 year ago

Thanks -- yeah, we would LOVE to move the Commit Details to the secondary side bar by default but VS Code doesn't allow it yet. You can vote on that feature here: https://github.com/microsoft/vscode/issues/151681

pavlelee commented 1 year ago

@eamodio another issue is if project have a lot of branches, when I develop on my branch, I want to see other branch history must switch to it, this is very trouble.

image
eamodio commented 1 year ago

@pavlelee You can just set it back to Show All Local Branches (which is the default)

pavlelee commented 1 year ago

@pavlelee You can just set it back to Show All Local Branches (which is the default)

Coincidentally, most of the scenes I mentioned are remote branches.

pavlelee commented 1 year ago

Thanks -- yeah, we would LOVE to move the Commit Details to the secondary side bar by default but VS Code doesn't allow it yet. You can vote on that feature here: microsoft/vscode#151681

I will vote, but I think panel are already fine, do you still need so many options?

eamodio commented 1 year ago

Coincidentally, most of the scenes I mentioned are remote branches.

The "Show All Local Branches" option is kind of misnamed, and we will change it to "Show All Branches" to be clearer. That first option is to choose between showing "all" branches or only the current branch, and the "Hide *" options further refine what should be shown.

eamodio commented 1 year ago

Closing this as we've added lots of improvements here and the new panel layout: https://github.com/gitkraken/vscode-gitlens/issues/2602

github-actions[bot] commented 1 year ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.