search

gitkraken / vscode-gitlens

Supercharge Git inside VS Code and unlock untapped knowledge within each repository — Visualize code authorship at a glance via Git blame annotations and CodeLens, seamlessly navigate and explore Git repositories, gain valuable insights via rich visualizations and powerful comparison commands, and so much more
http://gitkraken.com/gitlens
Other
9.01k stars 1.34k forks source link

`git-rebase-todo` setting does not respect `"git-rebase-todo": "default"` in a profile #2913

Open lgarron opened 1 year ago

lgarron commented 1 year ago

Description

Set the following in VS Code settings.json:

{
  "workbench.editorAssociations": {
    "git-rebase-todo": "default"
  },
  "workbench.settings.applyToAllProfiles": [
    "workbench.editorAssociations",
    "workbench.editorAssociations.git-rebase-todo",
  ],
}

And then invoke git rebase --interactive in a profile.

Also try the same with the setting explicitly copied into the profile.

No matter what, the setting is not respected.

I like most of GitLens, but there has been a history of the rebase editor sticking itself in your face with a bunch full of bugs and inconsistencies:

I don't seem to have recurring issues like this with features any other extension. When I turn off interactive rebase in GitLens, it should stay off.

GitLens Version

v14.3.0

VS Code Version

Version: 1.82.1 Commit: 6509174151d557a81c9d0b5f8a5a1e9274db5585 Date: 2023-09-08T08:49:22.656Z Electron: 25.8.0 ElectronBuildId: 23503258 Chromium: 114.0.5735.289 Node.js: 18.15.0 V8: 11.4.183.29-electron.0 OS: Darwin arm64 22.6.0

Git Version

git version 2.40.0

Logs, Screenshots, Screen Captures, etc

The Output pane is completely empty. Here's a screencap showing the issue:

https://github.com/gitkraken/vscode-gitlens/assets/248078/a3aae03f-505e-47f8-b039-a95569d09fd4

This may also independently be exhibiting https://github.com/gitkraken/vscode-gitlens/issues/1765

lgarron commented 1 year ago

This remains an issue. GitLens managed to corrupt one of my git repos due to this UI. It's stuck in a rebase, and git rebase --abort results in:

warning: could not read '.git/rebase-merge/head-name': No such file or directory