Webviews can have issues with high contrast themes

gitkraken / vscode-gitlens

Supercharge Git inside VS Code and unlock untapped knowledge within each repository — Visualize code authorship at a glance via Git blame annotations and CodeLens, seamlessly navigate and explore Git repositories, gain valuable insights via rich visualizations and powerful comparison commands, and so much more

http://gitkraken.com/gitlens

Other

9.04k stars 1.35k forks source link

Webviews can have issues with high contrast themes #3734

Closed d13 closed 1 week ago

d13 commented 1 week ago

Observed in https://github.com/gitkraken/vscode-gitlens/issues/3646

Essentially, anywhere we have CSS selectors for vscode-light and vscode-dark classes we also need to include vscode-high-contrast-light and vscode-high-contrast respectively.

sergeibbb commented 1 week ago

@d13

Where should I look at to reproduce the problem and to see that it's fixed. Was it a specific element of UI?

cc @nzaytsev

axosoft-ramint commented 1 week ago

Looks like we addressed this everywhere except for the graph minimap, but seeing no visual issues with it in high-contrast light or dark, I'm marking this as verified.