gitkraken / vscode-gitlens

Supercharge Git inside VS Code and unlock untapped knowledge within each repository — Visualize code authorship at a glance via Git blame annotations and CodeLens, seamlessly navigate and explore Git repositories, gain valuable insights via rich visualizations and powerful comparison commands, and so much more
http://gitkraken.com/gitlens
Other
8.95k stars 1.28k forks source link

Ctrl+Shift+G shown as keyboard shortcut, but doesn't work when GitLens is installed #423

Closed AArnott closed 6 years ago

AArnott commented 6 years ago

From @AArnott on June 13, 2018 14:1

Issue Type: Bug

When I hover over the button that activates the Git panel, it tells me that Ctrl+Shift+G will activate it. But it does not. Rather, that keystroke changes the status bar to indicate it is waiting for the second chord in a multi-keystroke sequence. Pressing Ctrl+Shift+G again is rejected as a non-existent chord.

VS Code version: Code 1.24.0 (6a6e02cef0f2122ee1469765b704faf5d0e0d859, 2018-06-06T17:35:40.560Z) OS version: Windows_NT x64 10.0.17134

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz (8 x 2112)| |GPU Status|2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: disabled_software
video_decode: enabled
video_encode: enabled
vpx_decode: enabled
webgl: enabled
webgl2: enabled| |Memory (System)|15.93GB (1.80GB free)| |Process Argv|C:\Program Files\Microsoft VS Code\Code.exe .\assert.xunit\| |Screen Reader|no| |VM|0%|
Extensions (19) Extension|Author (truncated)|Version ---|---|--- vscode-markdownlint|Dav|0.18.0 vscode-eslint|dba|1.4.12 githistory|don|0.4.1 xml|Dot|2.3.0 gitlens|eam|8.3.5 EditorConfig|Edi|0.12.4 tslint|eg2|1.0.30 git-project-manager|fel|1.6.1 docker-linter|hen|0.5.0 docomment|k--|0.1.0 azure-account|ms-|0.4.0 cpptools|ms-|0.17.4 csharp|ms-|1.15.2 liveshare-logviewer|ms-|0.2.1 PowerShell|ms-|1.7.0 team|ms-|1.136.0 vscode-docker|Pet|0.0.27 java|red|0.26.0 vsc-docker|Zim|0.34.0 (1 theme extensions excluded)

Copied from original issue: Microsoft/vscode#51767

AArnott commented 6 years ago

From @RMacfarlane on June 13, 2018 17:15

Can you run Preferences: Open Keyboard Shortcuts and search Show SCM to see what the binding for that is? Can you also check to see if you have any installed keymaps with Preferences: Keymaps?

AArnott commented 6 years ago

I don't have any installed keymaps.

Here is what I see on Open Keyboard Shortcuts: image

I have not modified these directly in any way.

Thanks.

AArnott commented 6 years ago

From @RMacfarlane on June 13, 2018 22:7

Ah, ok. It looks like the GitLens extension is using Ctrl+Shift+G as the prefix for its keybindings, which is why VSCode waits for more input. You can add "gitlens.keymap": "none" to your settings or use the Ctrl+Shift+G+G shortcut à la GitLens. Regardless, we should display the correct keybinding to open the view when you hover

AArnott commented 6 years ago

From @vscodebot[bot] on June 18, 2018 12:41

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines.

Happy Coding!

eamodio commented 6 years ago

Unfortunately I've gone through too many changes with key bindings conflicting with everything, so ultimately I added the quick escape hatch via gitlens.keymap which can be set to chorded (the default set), alternate (alt-based set), and none (no keybindings).

I would really love vscode to fix https://github.com/Microsoft/vscode/issues/40389 to reduce confusion, but at least for now I'm not planning on changing this.

Sorry.

gnppro commented 4 years ago

Git Source Control (SCM) => "ctrl+shift+g g" Git Lends => "ctrl+shift+g shift+b"

github-actions[bot] commented 3 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.