Open rudeb0y opened 5 years ago
Does anyone know what would need to be done to support this?
I successfully installed v9.9.1 into Azure Data Studio. I don't know the technical aspects as I'm not an extension author, but v9.9.2+ has the vscode engine in package.json set to "^1.36.0". Simply changing this wasn't enough as it seems there are dependencies on that particular version. Dropping back to v9.9.1 which used an older engine seems to be working nicely so far.
Is this still open, what would be needed to move packages like git lens and jumpy over to ADS from VSCode?
I'm not sure what is involved here, but last I looked into it (a long time ago), there was no marketplace or anything for ADS. And without something like that, I don't feel usage would be enough to warrant the work. But if the community wants to take this on (and its maintainable) I'd be open to it.
If i understand ADS correctly there is now a market place, I'll be more than happy to port this over if you are able to give me some instruction on how to do so.
@umarhussain88 I really appreciate that, but unfortunately I really don't know what needs to be done to support this.
Does anyone know?
I could install version v10.2.3 of GitLens into ADS v1.25.2 as VSIX. If I try to install latest GitLens version I'm getting the error:
Unable to install extension 'eamodio.gitlens' as it is not compatible with the current VS Code engine version '1.48.0'.
Hope this helps.
I would love this functionality as well. Am getting a similar error to keschner above:
Unable` to install extension 'eamodio.gitlens' as it is not compatible with the current VS Code engine version '1.51.0'.
I admit ignorance as to extension porting. I did find this tutorial , but I don't know how relevant/possible it would be for this extension.
I've gotten this extension to load in ADS 1.28.0 (VS Code 1.51.0) by changing the vscode version in package.json to match the version ADS is on. I assume this will cause problems for some dependencies that it appears ADS doesn't use. I also added the azdata engine with all versions because I don't know what I'm doing. :) But it compiled, and it's working fine in ADS -- whether it would cause issues in VS Code is unknown to me.
Changes:
"engines": { "vscode": "^1.51.0", "azdata": "*" },
"devDependencies": { "@types/chroma-js": "2.1.3", "@types/lodash-es": "4.17.4", "@types/node": "12.12.70", "@types/sortablejs": "1.10.6", "@types/vscode": "1.51.0", ... blah blah blah
@raeokay Unfortunately until ADS catches up to the required version of VS Code that GitLens requires there will be bugs and incompatibilities.
Well, it's now 2022 and this is still an issue. Just wanting to confirm that GitLens version 11.7.0 appears to be working with ADS version 1.38.0.
Unfortunately it's always going to be an issue unless ADS keeps far closer up to date with the vscode extension API. And as far as I know ADS still has no good way to really publish extensions to it.
GitKraken Team:
My data team uses ADS/Azure Data Studio over VSCODE, I am trying to argue for using VSCODE, but there are nagging differences and cargo-cult add-ins from SSMS that work with ADS and VSCODE.
That said, releasing GitLens for ADS would be a real win for productivity and reduce the need to keep another client tool, GitKraken Client UTD/Up-To-Date.
All the best,
Generally Happy User/Customer
I was just able to install gitlens in ADS using the .vsix with no problem.
⬆️ Upvote for this feature request
This would be a huge win for getting our DBAs using git.
Azure Data Studio is based off vscode, so this might be quite easy to port over to there?
I've tried installing the extension on Azure Data Studio via a .vsix but it does not work