gitlabform / gitlabform

🏗 Specialized configuration as a code tool for GitLab
https://gitlabform.github.io/gitlabform/
MIT License
393 stars 88 forks source link

fix: do not call get /member_roles when no member role set in config #775

Closed TimKnight-DWP closed 4 weeks ago

TimKnight-DWP commented 1 month ago

Won't get back to this until Monday if there are comments 👍

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 46.66667% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 85.98%. Comparing base (e5eea43) to head (d76bff2).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/gitlabform/gitlabform/pull/775/graphs/tree.svg?width=650&height=150&src=pr&token=3g2AMN9IlC&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gitlabform)](https://app.codecov.io/gh/gitlabform/gitlabform/pull/775?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gitlabform) ```diff @@ Coverage Diff @@ ## main #775 +/- ## =========================================== + Coverage 39.02% 85.98% +46.96% =========================================== Files 76 76 Lines 3108 3119 +11 =========================================== + Hits 1213 2682 +1469 + Misses 1895 437 -1458 ``` | [Files](https://app.codecov.io/gh/gitlabform/gitlabform/pull/775?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gitlabform) | Coverage Δ | | |---|---|---| | [gitlabform/gitlab/python\_gitlab.py](https://app.codecov.io/gh/gitlabform/gitlabform/pull/775?src=pr&el=tree&filepath=gitlabform%2Fgitlab%2Fpython_gitlab.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gitlabform#diff-Z2l0bGFiZm9ybS9naXRsYWIvcHl0aG9uX2dpdGxhYi5weQ==) | `61.66% <0.00%> (+20.28%)` | :arrow_up: | | [...abform/processors/group/group\_members\_processor.py](https://app.codecov.io/gh/gitlabform/gitlabform/pull/775?src=pr&el=tree&filepath=gitlabform%2Fprocessors%2Fgroup%2Fgroup_members_processor.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gitlabform#diff-Z2l0bGFiZm9ybS9wcm9jZXNzb3JzL2dyb3VwL2dyb3VwX21lbWJlcnNfcHJvY2Vzc29yLnB5) | `92.91% <77.77%> (+77.33%)` | :arrow_up: | | [gitlabform/processors/project/members\_processor.py](https://app.codecov.io/gh/gitlabform/gitlabform/pull/775?src=pr&el=tree&filepath=gitlabform%2Fprocessors%2Fproject%2Fmembers_processor.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gitlabform#diff-Z2l0bGFiZm9ybS9wcm9jZXNzb3JzL3Byb2plY3QvbWVtYmVyc19wcm9jZXNzb3IucHk=) | `80.95% <0.00%> (+65.95%)` | :arrow_up: | ... and [63 files with indirect coverage changes](https://app.codecov.io/gh/gitlabform/gitlabform/pull/775/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gitlabform)
TimKnight-DWP commented 1 month ago

Damn these were running locally - sorry out of time for now, main is currently also broken :(

Will come back Mon

TimKnight-DWP commented 4 weeks ago

Looks like GitHub workflows driven by on_call are not picking up the global environment variable being set :( So the tests are still checking out code from main