Correct git_dir for submodules

gitlabhq / grit

Grit gives you object oriented read/write access to Git repositories via Ruby. Patched for GitLab

gitlab.org

MIT License

59 stars 55 forks source link

Correct git_dir for submodules #29

Closed rsludge closed 9 years ago

rsludge commented 11 years ago

In submodule .git is not directory. It is a file with path to git directory like that: gitdir: /path/to/git/directory

coveralls commented 11 years ago

Coverage remained the same when pulling db57490312fc1fd5c2a1e9d24bfa6886374e1716 on rsludge:submodule_git_dir into ca49cdd437626af3088083a9ad0c49adacb7135f on gitlabhq:master.

jacobvosmaer commented 11 years ago

Could you maybe explain the purpose of this change? What would change in gitlabhq ?

rsludge commented 11 years ago

It will allow to handle submodule like an ordinary git repo

jacobvosmaer commented 11 years ago

Can you explain a use case?

simonzack commented 9 years ago

@jacobvosmaer I think a use case for this would be to let gollum wiki handle submodules correctly, which depends on grit (the upstream grit is no longer maintained).

jacobvosmaer commented 9 years ago

Pardon my bluntness, but: the primary interest of the maintainers of this gem (GitLab Core Team) is to improve GitLab. It is not clear how this change improves GitLab.

Closing this PR because it has gone stale by now.

cc @randx