gitlabhq / grit

Grit gives you object oriented read/write access to Git repositories via Ruby. Patched for GitLab
gitlab.org
MIT License
59 stars 55 forks source link

Fix spawn of compress_cmd hang #42

Closed radioactive42 closed 10 years ago

radioactive42 commented 10 years ago

Spawn of compress_cmd hangs if pipe_wr is not closed before spawning. Should fix: gitlabhq/gitlabhq#6922

This bug hits the download as archive function. It makes the website hang when trying to download an archive and can create empty tar.gz files.

jvanbaarsen commented 10 years ago

@randx Looks good to merge

dzaporozhets commented 10 years ago

This one https://github.com/gitlabhq/grit/commit/49a1226a26cf6fb9039d852f13598abcc0d0fd39 already in master