gitlabhq / grit

Grit gives you object oriented read/write access to Git repositories via Ruby. Patched for GitLab
gitlab.org
MIT License
59 stars 55 forks source link

Update mime types dependency #57

Closed rymai closed 7 years ago

rymai commented 7 years ago

We need to remove the < 3 condition on the mime-types dependency to be able to upgrade google-api-client which depends on mime-types ~> 3.0.

See https://gitlab.com/gitlab-org/gitlab-ce/issues/38286#note_41303108 for more details.

/cc @godfat

dosuken123 commented 7 years ago

This is critical for https://gitlab.com/gitlab-org/gitlab-ce/issues/35954. I hope we can merge this soon.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling a1e79aa05448b09885e4fe18fabc26c764c92f5a on update-mime-types-dependency into on master.

dzaporozhets commented 7 years ago

@dosuken123 how exactly its related?

Edit: nevermind, I see we need it depends on google-api-client

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling d1ed539f0326375f58f8a6709862145670bfdc13 on update-mime-types-dependency into on master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling f1ab3b51156adb071c833017d35ce70ffe91312d on update-mime-types-dependency into on master.

dzaporozhets commented 7 years ago

@rymai I pushed 2.8.2 to rubygems

rymai commented 7 years ago

@dzaporozhets Thanks!