support ruby 2.0 - Githubissues

gitlabhq / grit

Grit gives you object oriented read/write access to Git repositories via Ruby. Patched for GitLab

gitlab.org

MIT License

59 stars 55 forks source link

support ruby 2.0 #9

Closed fdiary closed 11 years ago

fdiary commented 11 years ago

Hello,

Current grit does not work because

version checking condition does not work for ruby-2.0.
PACK_IDX_SIGNATURE string is treated as UTF-8 in ruby 2.0.

I confirmed that tests still pass on ruby 1.9.3p392 and on ruby 2.0.0p0 with this change. FYI to run tests on ruby 2.0.0p0 we also need to modify mocha like https://github.com/freerange/mocha/commit/cf91bded89fe2172f2f82146aaacaa520f564b0 .

Kazuhiko

vsizov commented 11 years ago

I think we should wait for next patch-level

vsizov commented 11 years ago

thank you anyway

fdiary commented 11 years ago

I think we should wait for next patch-level

Well, the official announcement of ruby 2.0.0p0 says : "Note that unlike 1.9.0, 2.0.0 IS a stable release, even though its TEENY is 0. All library authors are strongly recommended to support 2.0.0." :smiley: http://www.ruby-lang.org/en/news/2013/02/24/ruby-2-0-0-p0-is-released/

dzaporozhets commented 11 years ago

Thank you

davispuh commented 11 years ago

probably best would be migrate from Grit to Rugged altogether, but I don't expect it soon. Grit seems abandoned and have some issues, while personally I haven't experienced any problems with it using Gitlab I think it would be good move.

BTW gollum have started migrating already github/gollum#617

dzaporozhets commented 11 years ago

migrate to rugged its not a first priority since grit works well for now