search

gitless-vcs / gitless

A simple version control system built on top of Git
https://gitless.com
MIT License
1.92k stars 106 forks source link

`gl commit -e` conflicts with `git` option #55

Open techtonik opened 8 years ago

techtonik commented 8 years ago

-e option is already taken in git, which may create confusion when switching back and forth. How about -x instead?

spderosso commented 8 years ago

The problem with using -x is that it would break the convention that the short form of an option corresponds to the first letter of its long form (-i is short for --include, -o for --only, and -e for --exclude) and it seems to me that the use of -e in git commit is not as common as to merit breaking the convention due to the clash

techtonik commented 8 years ago

-x is a common convention for various ex commands, so -x for --exclude is also ok.

techtonik commented 8 years ago

Also, hg uses -I and -X switches for that:

 -I --include PATTERN [+] include names matching the given patterns
 -X --exclude PATTERN [+] exclude names matching the given patterns
spderosso commented 8 years ago

Ok, you have convinced me that this is a good idea