search

gitlist-php / gitlist

An elegant and modern git repository viewer
BSD 3-Clause "New" or "Revised" License
5 stars 0 forks source link

gitter / gitlist #10

Closed p3x-robot closed 7 years ago

p3x-robot commented 7 years ago

you can merge my repo, it has all latest sliex 2, php 7, 17 bootstrap themes, plus it adds gitter, as well, that needed update as well....

https://github.com/patrikx3/gitlist

https://github.com/patrikx3/gitter

https://gitlist.patrikx3.com/

alehaa commented 7 years ago

This topic is discussed in #4 and #7.

alehaa commented 7 years ago

@p3x-robot for several reasons we can't merge your fork. Let me describe the reasons:

  1. You've changed the license from BSD to MIT. I'm not a lawyer, but in many countries this is illegal, as you need permission from the original author. In addition I don't advocate writing your name before the one of @klaussilveira, as he found the project and wrote most of the code.
  2. None of your commits has any kind of comment. I don't know what you've done and why you did it. E.g. you've added lots of new files - and I don't know what these are used for.
  3. I think 17 bootstrap themes are way to much for this project, as it should be minimalistic. Additional templates should be shipped in a separate repository.

However, I think we can take a look at some of your commits for rewriting them (e.g. #4).

PABourdin commented 7 years ago

I agree with alehaa's comments. Please write meaningful commit messages. Thank you.