search

gitlist-php / gitlist

An elegant and modern git repository viewer
BSD 3-Clause "New" or "Revised" License
5 stars 0 forks source link

Feature/silex2 #12

Closed PABourdin closed 7 years ago

PABourdin commented 7 years ago

Migration to Silex 2 and Symphony 2.8, please review.

alehaa commented 7 years ago

I believe some of the changes belong to other pull requests or forks (see #7), e.g. 

-    public function getHead()
+    public function getHead($default = NULL)

I will check this PR after merging the other orphan forks. Thanks @PABourdin! ;)

PABourdin commented 7 years ago

@alehaa Yes, there is another branch with only this change. Nonetheless, I wanted to fix this already during the Silex 2 migration because of a relatively clear warning (PHP notice). You may of course first pull in the other branch, followed by this PR, if you like. There should not arise a conflict, I hope.

PABourdin commented 7 years ago

The feature/silex2 branch can be deleted now, I guess? Or do you want to keep it? Thanks @alehaa

alehaa commented 7 years ago

Done.