search

gitlocalize / feedback

:mega: We love feedback :sparkles:
20 stars 8 forks source link

Sync with GitHub #115

Closed ava57r closed 1 year ago

ava57r commented 2 years ago

Hello.

Please, explain how does it work?

Some people like send PR from Github for fixing translation errors. How does GL sync these from GH.

Thanks.

ava57r commented 2 years ago

I can add suggestions in gitlocalize bot PR before merge. What does it happen with fixes?

ilyaspiridonov commented 2 years ago

Some people like send PR from Github for fixing translation errors. How does GL sync these from GH.

Hi, thanks for your inquiry. As long as the file is 'Synced' (no open PRs), changes made on the GitHub end should be synced into the GitLocalize project (as GitHub is always used as 'source of truth')

ilyaspiridonov commented 2 years ago

I can add suggestions in gitlocalize bot PR before merge. What does it happen with fixes?

@svasilenkov Can you look into this? My understanding is that we won't be able to 'commit' those suggestions, as the PR is authored by Gitlocalize-bot. @ava57r Unless you can commit those suggestions yourself (not sure if GitHub allows to do that) On another note, Gitlocalize-bot creates a new branch when opening a PR, so in theory you should be able to push changes to that branch from your local git (and those changes should update the PR created by gitlocalize-bot).

ilyaspiridonov commented 2 years ago

What kind of changes in the PR are you referring to? Linguistic (wording, style, grammar etc) or technical (anything GitLocalize may mess with?)

ava57r commented 2 years ago

What kind of changes in the PR are you referring to? Linguistic (wording, style, grammar etc) or technical (anything GitLocalize may mess with?)

invalid links spell checking

https://github.com/rust-lang-ru/book/pull/1029 https://github.com/rust-lang-ru/book/pull/1028

style https://github.com/rust-lang-ru/book/pull/1025

ava57r commented 2 years ago

What kind of changes in the PR are you referring to? Linguistic (wording, style, grammar etc) or technical (anything GitLocalize may mess with?)

Gitlocalize does not have spellchecking =(

We check https://github.com/rust-lang-ru/book/blob/master/.github/workflows/main.yml#L18

ilyaspiridonov commented 2 years ago

for anything text-related (grammar/spelling etc) you can make changes on Gitlocalize even after creating the PR:

Screenshot 2022-08-24 at 13 11 07

Updates will be sent as a separate commit to the same branch (i.e. will appear on the same PR)

ilyaspiridonov commented 2 years ago

For the links: does this keep happening often or was that a more like a one-off case scenario?

ava57r commented 2 years ago

For the links: does this keep happening often or was that a more like a one-off case scenario?

rarely

Some people don't want to use your system One of reasons pipeline translate -> create GL PR (translator) -> create GH PR(moderator)

They like to create GH PR directly.

ava57r commented 2 years ago

I can add suggestions in gitlocalize bot PR before merge. What does it happen with fixes?

@svasilenkov Can you look into this? My understanding is that we won't be able to 'commit' those suggestions, as the PR is authored by Gitlocalize-bot. @ava57r Unless you can commit those suggestions yourself (not sure if GitHub allows to do that) On another note, Gitlocalize-bot creates a new branch when opening a PR, so in theory you should be able to push changes to that branch from your local git (and those changes should update the PR created by gitlocalize-bot).

I added suggestions here https://github.com/rust-lang-ru/book/pull/1029

after merge segments were untranslate in GL.

I created a new PR from GL https://github.com/rust-lang-ru/book/pull/1030

ava57r commented 2 years ago

batch fix https://github.com/rust-lang-ru/book/pull/1025

it easier to fix from git then GitLocalize web interface

svasilenkov commented 2 years ago

@svasilenkov Can you look into this? My understanding is that we won't be able to 'commit' those suggestions, as the PR is authored by Gitlocalize-bot. @ava57r Unless you can commit those suggestions yourself (not sure if GitHub allows to do that) On another note, Gitlocalize-bot creates a new branch when opening a PR, so in theory you should be able to push changes to that branch from your local git (and those changes should update the PR created by gitlocalize-bot).

@ilyaspiridonov I have tested the following:

  1. Created review request in GitLocalize.
  2. Created pull request authored by GitLocalize.
  3. Made a commit into the pull request at GitHub with some changes.
  4. Merged the pull request.
  5. GitLocalize successfully synced from GitHub all changes made at the step 3.