gitlocalize / feedback

:mega: We love feedback :sparkles:
20 stars 8 forks source link

Match html lang attribute to translation #139

Open mattgarrish opened 4 months ago

mattgarrish commented 4 months ago

Summary

Translated html pages always get the language of the source.

Steps to reproduce

Translate any html page with a lang attribute on the root html element.

What is the current bug behavior?

The lang attribute value in the translated document has the same language code as the source. Update the translation and a corrected lang attribute reverts to the source language code.

What is the expected correct behavior?

Match the language code to the translation.

Possible fixes

Automatic updating of the lang attribute to match the translation language would be nice, or at least a way to set the attribute during translation of documents and have that remembered across updates.

svasilenkov commented 4 months ago

@mattgarrish Thank you for the suggestion.