search

gitlocalize / feedback

:mega: We love feedback :sparkles:
20 stars 8 forks source link

Non selectable code blocks #55

Closed funkill closed 5 years ago

funkill commented 5 years ago

Summary

Some code blocks in markdown files (maybe only Rust-specific derivation) not detects as segment.

Steps to reproduce

  1. Open repo
  2. Try to translate first code block (fail, not selectable)
  3. Try to translate second code block (success, selectable).

Repository URL

https://gitlocalize.com/repo/2509/ru/rust-by-example/src/flow_control/if_let.md

What is the current bug behavior?

Some code block not selectable.

What is the expected correct behavior?

Code blocks can be selectable for translation like other blocks.

svasilenkov commented 5 years ago

Has been fixed, please check this out.

funkill commented 5 years ago

Not work.

Tested in Safari 13.0 (15608.1.31.1.2), Firefox 70.0a1 (2019-07-08) on MacOS and Firefox 67.0.4 on Linux

svasilenkov commented 5 years ago

It is finally done, now it should work as expected.

funkill commented 5 years ago

Thank you! Works great!

funkill commented 5 years ago

Found new non selectable code block in https://gitlocalize.com/repo/2509/ru/rust-by-example/src/std_misc/path.md, https://gitlocalize.com/repo/2509/ru/rust-by-example/src/std/str.md, https://gitlocalize.com/repo/2509/ru/rust-by-example/src/testing/unit_testing.md and https://gitlocalize.com/repo/2509/ru/rust-by-example/src/std_misc/threads/testcase_mapreduce.md

svasilenkov commented 5 years ago

The problem has been fixed for these files too.

funkill commented 5 years ago

Thanks!