gitlocalize / feedback

:mega: We love feedback :sparkles:
20 stars 8 forks source link

Extra < comment > < / comment > elements are generated in MD link #93

Open blandger opened 3 years ago

blandger commented 3 years ago

Extra < comment > < / comment > elements are generated in MD link

Here is an example of not quite correct processing MD link element.

Steps to reproduce

See original raw text here inside Processing a Guess: https://raw.githubusercontent.com/rust-lang/book/master/src/ch02-00-guessing-game-tutorial.md

By default, Rust brings only a few types into the scope of every program in
[the *prelude*][prelude]<!-- ignore -->..........

Repository URL

https://gitlocalize.com/repo/4579/ru/rustbook-en/src/ch02-00-guessing-game-tutorial.md

English is rendered as: By default, Rust brings only a few types into the scope of every program in {a0}the {em1}prelude{/em1}{/a0}{comment2} ignore {/comment2}.

Russian is rendered as По умолчанию, Rust автоматически подключает несколько типов данных в область видимости каждой программы ({a0}{em1}авто-импорт - prelude{/em1}{/a0}){comment2} <!-- -->{/comment2}.

What is the current bug behavior?

Extra element is generated by GL then file is pushed back into GH. See here https://github.com/rust-lang-ru/book/pull/343/files По умолчанию, Rust автоматически подключает несколько типов данных в область видимости каждой программы ([*авто-импорт - prelude*](https://doc.rust-lang.org/std/prelude/index.html))<comment> ignore</comment>.

What is the expected correct behavior?

I suppose that might be generated as correct MD link: По умолчанию, Rust автоматически подключает несколько типов данных в область видимости каждой программы ([*авто-импорт - prelude*](https://doc.rust-lang.org/std/prelude/index.html)).

Relevant logs and/or screenshots

Correct links in MD specification is here https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet#links

svasilenkov commented 3 years ago

The problem should be fixed at the moment. @blandger Could you please check if it is still there?

blandger commented 3 years ago

close that now. We'll check that later on next translation attempts.