search

gitmachtl / scripts

StakePool Operator Scripts. Learn how to create and manage your StakePool / manage your DRep stuff / do Governance Actions with these simple scripts. Hardware-Ledger/Trezor Support, Token/Asset Sending, Offline-Mode and much more...
MIT License
271 stars 95 forks source link

feat: support multiple pool node key on same HW wallet #41

Closed ArchiFleKs closed 1 year ago

ArchiFleKs commented 1 year ago

Signed-off-by: Kevin Lefevre kevin@particule.io

gitmachtl commented 1 year ago

hi, thx for the commit. let me check it, because this an "out of the specs" feature. let me talk with my buddies from vacuumlabs if this is ok. i am currently away and will check this out on the weekend. best regards, martin

ArchiFleKs commented 1 year ago

@gitmachtl Yes the specs is supposed to be hardcoded. Do you think this could lead to issues ? I launched 3 pools using the same ledger.

gitmachtl commented 1 year ago

yep, the CIP is using the hardened index 0 for that. i contacted samuel leathers to get a feedback on that topic too. i do stuff that "hey it just works" all the time :-) but would be good to have an ok on that from them.

gitmachtl commented 1 year ago

ColdKeyIndex option is now added into the scripts https://github.com/gitmachtl/scripts/commit/2d5bf77bbf0a54602eba88844d9a8d97bf6d242a

Its working for the whole range 0-2147483647

Best regards, Martin

ArchiFleKs commented 1 year ago

ColdKeyIndex option is now added into the scripts https://github.com/gitmachtl/scripts/commit/2d5bf77bbf0a54602eba88844d9a8d97bf6d242a

Its working for the whole range 0-2147483647

Best regards, Martin

Nice thank you