gitmedha / sis-frontend

Latest Medha Project from Scratch
GNU Affero General Public License v3.0
0 stars 0 forks source link

Institution detail page - contact section updates #20

Closed rathorevaibhav closed 3 years ago

rathorevaibhav commented 3 years ago

Describe the task Cleanups needed for institution contact functionality

Expected behavior

swapneelrane commented 3 years ago

@rathorevaibhav have tested 4/5 features above ... just need to test the remaining one on mismatched picklist values, but the frontend is not loading at https://sis-new.medha.org.in/, I think cause the yml file for the CI workflow has not been updated

@abhishek-pokhriyal , since you are merging the pull requests, can you also update the PUBLIC_URL here: https://github.com/gitmedha/medha-react-ui/blob/main/.github/workflows/main.yml

image

rathorevaibhav commented 3 years ago

Targeted this file update at #33

swapneelrane commented 3 years ago

I think this is mostly happening with older institutions, but the Detail page show Status = Active while it is unselected in the Edit modal for the same institution. This gets fixed once you save it.

image

rathorevaibhav commented 3 years ago

@swapneelrane this is ready to test

swapneelrane commented 3 years ago

@rathorevaibhav what exact functionality do you want me to test?

rathorevaibhav commented 3 years ago

oh the feedback from you. About the unselected status for old data.

swapneelrane commented 3 years ago

Ok, that doesn't seem to have been fixed yet. See this record: https://sis-new.medha.org.in/institution/22

rathorevaibhav commented 3 years ago

@swapneelrane I'm not sure what exactly you mean in that record. I see the status is coming fine in the edit form.

To show the additional option for picklist that's not in the default list, that is being tracked in #36

swapneelrane commented 3 years ago

Oh cool. Closing this then.