gitn00b1337 / expo-widgets

Bringing widget functionality to expo!
110 stars 9 forks source link

Issue with @sentry/react-native #22

Open zRelux opened 1 month ago

zRelux commented 1 month ago

Sorry that I cannot raise a PR but unfortunately I am extremely busy with work. Basically these lines in the podfile create issues with the sentry/react-native: config.build_settings['APPLICATION_EXTENSION_API_ONLY'] = 'No'

The proposed solution would be:

app_ext_fix

config.build_settings['APPLICATION_EXTENSION_API_ONLY'] = resource_bundle_target.name == 'Sentry' ? 'YES' : 'No'

where as for fix2

config.build_settings['APPLICATION_EXTENSION_API_ONLY'] = target.name == 'Sentry' ? 'YES' : 'No'   

see here for more info

gitn00b1337 commented 1 month ago

Hi,

The proposal here is too focused on a separate product - it shouldn't list sentry specific. From what I gather reading that issue, sentry crates a new iOS target and THAT target needs api set to yes. Is this correct?

It's also unclear whether the main target also needs this or not.

Please let me know. I'm thinking the pod file could be made more specific to only set yes on the widget extension target and possibly main target (needs testing if needed). This would then fix the sentry issue without introducing any dodgy patch

Thanks

zRelux commented 1 month ago

Unfortunately I am not well versed in the world of IOS target to fully grasp the issue, I do agree that sentry is a bit too specific, I guess as long as you are aware of the issue you'll find the right solution. But is good to have the issue here so people that have the same problem will find it