gitname / react-gh-pages

Deploying a React App (created using create-react-app) to GitHub Pages
6.6k stars 922 forks source link

Tutorial does not indicate that Vite would store the build in `dist` instead of `build` #155

Open munyanezaarmel opened 1 year ago

munyanezaarmel commented 1 year ago

Explanation: In my case, I was using Vite to create my React app. So by running npm run deploy, vite created a 'dist' folder for the production. But "deploy": "gh-pages -d build" is watching for the build folder. Now gh-pages will look for dist folder before deployment.

I think the docs should be updated as many people are using vite now

Otcocuka commented 1 year ago

My man, I use vite too and had the same problem. Just solved it Use "dist" instead of "build" property in package.json Screenshot 2023-08-05 152604

ceotrammell commented 1 year ago

My my, I use vite too and had the same problem. Just solved it Use "dist" instead of "build" property in package.json Screenshot 2023-08-05 152604

You are a life saver... this should be noted somewhere in docs or resolved