gitops-bridge-dev / gitops-bridge

Apache License 2.0
286 stars 76 forks source link

Metrics server should always be enabled when ArgoCD is deployed with the default configuration #69

Open irizzant opened 1 month ago

irizzant commented 1 month ago

ArgoCD with the default configuration uses HPA, which is useless without metrics server.

All the examples have metrics server disabled and ArgoCD enabled, see e.g https://github.com/gitops-bridge-dev/gitops-bridge/blob/66bde3ec1d3ed50248ba4d25b8979141837be01a/argocd/iac/terraform/examples/eks/crossplane/main.tf#L80 https://github.com/gitops-bridge-dev/gitops-bridge/blob/66bde3ec1d3ed50248ba4d25b8979141837be01a/argocd/iac/terraform/examples/eks/crossplane/main.tf#L94

csantanapr commented 1 month ago

Nice catch @irizzant you are correct it should be enable by default, people can choose to disable it