search

gitpod-io / contribute.dev

A list of cool open-source projects that you can contribute to with one click
https://contribute.dev
MIT License
80 stars 22 forks source link

wip: v2 updates #99

Closed nisarhassan12 closed 4 years ago

nisarhassan12 commented 4 years ago

any reasons why you used Montserrat instead of Lato which is used in the mockup? Just curious, you can also keep it like this

Thanks, @ChristinFrohne Sorry that I ignored the font change in the mock-up and used Montserrat I think without a clear reason in mind(Not sure what I thought about it) but now I have changed it to Lato which looks nice.

nisarhassan12 commented 4 years ago

@ChristinFrohne Please provide me with the URL for the 3rd tweet from Ancient Beast shown in the mock-up below. I was not able to find it myself.

image

chrifro commented 4 years ago

@ChristinFrohne Please provide me with the URL for the 3rd tweet from Ancient Beast shown in the mock-up below. I was not able to find it myself.

You can either use the three existing quotes or add ancient beast as well. Whatever fits best. But we won't need a scrolling here as there are so few quotes https://twitter.com/AncientBeast/status/1194754176900902917

nisarhassan12 commented 4 years ago

@ChristinFrohne I think using 3 existing ones is ok. I have updated the layout for the tweets please have a look again. Thanks

nisarhassan12 commented 4 years ago

Tweets: doesn't the ancient beast tweet fit perfectly in the current tweet layout. Please add it if you agree

Thanks, it does not fit correctly in the current layout due to the height of the contents this is how it looks:

image

nisarhassan12 commented 4 years ago

@ChristinFrohne I have made the requested change please have a look whenever you'll have time. Thanks.