search

gitpod-io / dockerfreeze

Freeze your development environment as a Dockerfile
MIT License
12 stars 4 forks source link

Fix shellcheck lints #50

Open JesterOrNot opened 4 years ago

JesterOrNot commented 4 years ago

:octocat: Any better @Kreyren

JesterOrNot commented 4 years ago

The shebang line breaks it

JesterOrNot commented 4 years ago

But removing it triggers a shellcheck lint

JesterOrNot commented 4 years ago

@Kreyren care to weigh in?

Kreyren commented 4 years ago

See https://github.com/gitpod-io/dockerfreeze/pull/54 and https://github.com/Kreyren/dockerfreeze/pull/1

https://github.com/Kreyren/dockerfreeze/blob/bdbf6e27cfb2933ebb0bef421c029dad2ef6ac95/tools/dockerfreeze

I was fixing bashisa and fixed the dockerfreeze while i was working on it can we process the changes here?

Kreyren commented 4 years ago

The shebang line breaks it

We can specify a directive for it so that shellcheck would know how to process the file.

See https://github.com/koalaman/shellcheck/wiki/Directive#shell

Kreyren commented 4 years ago

But removing it triggers a shellcheck lint

Currently blocked by https://github.com/actions/checkout/issues/175 since github's shellcheck is too old to be reliable

JesterOrNot commented 4 years ago

I was fixing bashisa and fixed the dockerfreeze while i was working on it can we process the changes here?

Explain

Kreyren commented 4 years ago

@JesterOrNot Explain

Review https://github.com/Kreyren/dockerfreeze/blob/bdbf6e27cfb2933ebb0bef421c029dad2ef6ac95/tools/dockerfreeze and adapt the changes in this merge request since it resolves the mensioned issues above already so that i can keep #54 for bashilisa only.