search

gitpod-io / dockerfreeze

Freeze your development environment as a Dockerfile
MIT License
12 stars 4 forks source link

CI: Check Bash completion and refactor #54

Closed Kreyren closed 4 years ago

Kreyren commented 4 years ago

Currently bashlisa ignores bash completion since it does not end with **.bash -> this should fix it

JesterOrNot commented 4 years ago

Why add gradelw?

Kreyren commented 4 years ago

@JesterOrNot because i already resolved this issue on https://github.com/Kreyren/revolution-irc and i forgot to change it

JesterOrNot commented 4 years ago

Ok

Kreyren commented 4 years ago

@JesterOrNot i will probably spam here (working with workflows is pita), feel free to unsubscribe i will ping you when it's ready

Kreyren commented 4 years ago

credit #bash for pointing out pitfalls

Kreyren commented 4 years ago

affected by https://github.com/koalaman/shellcheck/issues/1771

Kreyren commented 4 years ago

@JesterOrNot Ready for review

Kreyren commented 4 years ago

DO_NOT_MERGE: i can resolve the issue with shellcheck

Kreyren commented 4 years ago

Currently blocked by https://github.com/actions/checkout/issues/175

Kreyren commented 4 years ago

@JesterOrNot Works now, ready for review

Kreyren commented 4 years ago

@JesterOrNot Please squash in case we need to backtrack issues

JesterOrNot commented 4 years ago

Squashed

JesterOrNot commented 4 years ago

Fixed commit description to remove the spam commit description

Kreyren commented 4 years ago

Squashed

I meant squash using GitHub so that we can keep the commits on the branch.. Well too late now.. >.>

JesterOrNot commented 4 years ago

Sorry 😅

Kreyren commented 4 years ago

@JesterOrNot Check again should be perfect now ^-^

Kreyren commented 4 years ago

@JesterOrNot anything else?