gitpod-io / gitpod

The developer platform for on-demand cloud development environments to create software faster and more securely.
https://www.gitpod.io
GNU Affero General Public License v3.0
13.01k stars 1.24k forks source link

TOML Support #102

Closed svenefftinge closed 5 years ago

svenefftinge commented 6 years ago

We could possibly leverage configuration and LS from https://github.com/bungcip/better-toml

jankeromnes commented 5 years ago

Great idea! @akosyakov do you think we could install it as a VSCode extension in Gitpod's Theia, or would it be more practical to steal/import its configuration and language server directly?

akosyakov commented 5 years ago

Right now there is no way to install VS Code extensions in Gitpod. We could start by trying out support of better-toml with pure Theia and raise issues for missing APIs and metadata support.

In order to try with local Theia:

You can try it with Gitpod using the browser app from Theia repo.

jankeromnes commented 5 years ago

Thanks @akosyakov. I'll soon try using the TOML VSCode extension in Theia directly, and file any bugs I encounter.

@svenefftinge In the short term, TOML is very close to INI, which Theia already supports. Do you think it's possible to somehow coerce Gitpod into syntax-highlighting TOML as INI? It would look like this:

screenshot 2019-01-10 at 16 09 20
jankeromnes commented 5 years ago

I extended Theia's INI grammar to include .properties and .toml files in https://github.com/theia-ide/theia/pull/4015.

This should make TOML support good enough until we can use the VSCode extension with its language server.

svenefftinge commented 5 years ago

Great, then let's close this issue.

jankeromnes commented 5 years ago

Having the language server you mentioned would be great as well, but I agree that it can wait that VSCode extensions are well supported.