search

gitpod-io / gitpod

The developer platform for on-demand cloud development environments to create software faster and more securely.
https://www.gitpod.io
GNU Affero General Public License v3.0
12.51k stars 1.2k forks source link

File Icon for `.gitpod.yml` #10479

Open Siddhant-K-code opened 2 years ago

Siddhant-K-code commented 2 years ago

Describe the behaviour you'd like

To have a Gitpod logo in .gitpod.yml file icon like all other products have (imgs below)

Screenshots ![image](https://user-images.githubusercontent.com/55068936/172098621-2f0e4169-596d-4e89-8f2c-fd7306c0391d.png) ![image](https://user-images.githubusercontent.com/55068936/172098630-4479e910-af29-49f8-91bb-d980037ff503.png) ![image](https://user-images.githubusercontent.com/55068936/172098637-44d28311-f6f2-4c62-b39f-f2af9456b741.png)

Describe alternatives you've considered

Alternative Suggested by @axonasif to use material-icon-theme, will look something like this:

Screenshot ![image](https://user-images.githubusercontent.com/55068936/172098729-4febf745-8531-43fa-ad9c-99edf57b097f.png)

Additional context

Extension API (in VS Code): https://code.visualstudio.com/api/extension-guides/file-icon-theme

asmitbm commented 1 year ago

Can I pick this up?

asmitbm commented 1 year ago

I checked the gitpod-vscode-desktop repo, and it already has an icon file in package,json. Is this issue fixed?

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Siddhant-K-code commented 1 year ago

It uses Seti for default file icons. We would need to add the icon there. Also, Read this.

Resources:

Can I pick this up?

@Asmit2952 If you are still interested, you can send out the PR, Let me know, and I can assign you this.

ShashwatNautiyal commented 1 year ago

Hey, I have added and created a PR for Gitpod Icon in Seti. You can assign this issue to me.

akosyakov commented 1 year ago

cc @gtsiolis @chrifro

Siddhant-K-code commented 1 year ago

Thanks, @ShashwatNautiyal. I can assign this to you. I've left a comment (https://github.com/jesseweed/seti-ui/pull/673#pullrequestreview-1274286840) on the PR

ShashwatNautiyal commented 1 year ago
image

As per the seti-ui the icon must have a single color while the official SVG has a linear gradient and the size of the icon must be 18x18 with a 32x32 frame.

So I have tweaked the official icon size in the sketch and updated the SVG to match with seti-ui requirements.

gtsiolis commented 1 year ago

Cross-posting for visibility a comment I left in the relevant PR:

Cc @ShashwatNautiyal @Siddhant-K-code @chrifro @akosyakov

ShashwatNautiyal commented 1 year ago

I have updated the SVG and left a comment on the PR.

https://github.com/jesseweed/seti-ui/pull/673#issuecomment-1408600555

Cc @gtsiolis

beRajeevKumar commented 1 year ago

Is this issue still open! If is it then please assign it to me.

Siddhant-K-code commented 1 year ago

Is this issue still open! If is it then please assign it to me.

Thanks for your interest, @Rajeevjewar. Issue is still open, but it's implemented (https://github.com/jesseweed/seti-ui/pull/673) and the action item is due on seti's side 😄