Usage-based pricing - validate that self-hosted Gitpod users are not impacted by UBP changes

gitpod-io / gitpod

The developer platform for on-demand cloud development environments to create software faster and more securely.

https://www.gitpod.io

GNU Affero General Public License v3.0

12.9k stars 1.24k forks source link

Usage-based pricing - validate that self-hosted Gitpod users are not impacted by UBP changes #12969

Closed jldec closed 2 years ago

jldec commented 2 years ago

Feature flags should ensure that there is no impact of UBP on self-hosted Gitpod installations, but this needs to be validated.

no unexpected UBP-related errors during install or at run-time
no billing config or usage view for teams or individuals
no workspace or prebuild errors related to usage limits

known issues

[x] #13390
[x] #13392
[x] #13395

geropl commented 2 years ago

For ensuring exactly this we introduced the concept of BillingMode, with the possible values of none, chargebee and usage-based. And the relevant lines of code are here: if enablePayment is not set to true by the installer, the BillingMode for all users (and teams) defaults to none.

This BillingMode influences three things (which cover all ground mentioned above):

it governs what users can see on the dashboard (an improvement over the prior state!)
it governs what API users can use (e.g., being allowed to call upgradeSubscription or not)
it governs which implementation (strategy) of the EnttilementService is used to figure out what a user is entitled to do. Here's the implementation for none (should be named license, really. My fault :roll_eyes: ): EntitlementServiceLicense

That being said: we should still test, though. :upside_down_face:

AlexTugarev commented 2 years ago

Request deleteTeam failed with message: Stripe is not properly configured

This error blocks from team deletion, if payment is not configured.

lucasvaltl commented 2 years ago

@geropl what is the ask here towards the self-hosted team? If this is about spinning up self-hosted environments to test this, you should be able to use the environments during next week's release week to test this :)

geropl commented 2 years ago

@lucasvaltl Absolutely! This was before "release week" was decided :wink:

svenefftinge commented 2 years ago

We should target adding the usage view with the next (October) release.

geropl commented 2 years ago

Issue: "Usage View" is visible in self-hosted but shows broken content. (context: https://gitpod.slack.com/archives/C01KLC56NP7/p1664288507520209 )

jldec commented 2 years ago

FYI - edited issue description to include 2 new issues as sub-tasks (fix usage view and team deletion)

adrienthebo commented 2 years ago

This item has been marked as completed in the 2022.09.0 release document (internal notion), I believe this issue is done.