gitpod-io / gitpod

The developer platform for on-demand cloud development environments to create software faster and more securely.
https://www.gitpod.io
GNU Affero General Public License v3.0
12.81k stars 1.23k forks source link

[prebuilds] Disable prebuilds from bots by default #16386

Closed AlexTugarev closed 1 year ago

AlexTugarev commented 1 year ago

Considering push events caused by bots on GitHub for prebuild triggers doesn't seem to be a good idea:

The suggestion here is to flip the default and disable the prebuilds for such events. We can improve as a follow-up to introduce an option for projects to let them run on demand.

From the payload of a push event, we can easily detect if the change was caused by a bot:

    "sender": {
        "login": "dependabot[bot]",
        "id": 49699333,
        "avatar_url": "https://avatars.githubusercontent.com/in/29110?v=4",
        "url": "https://api.github.com/users/dependabot%5Bbot%5D",
        "html_url": "https://github.com/apps/dependabot",
        "type": "Bot",
        // ...
    },
AlexTugarev commented 1 year ago

cc. @atduarte and @geropl, I think this is low hanging and would increase efficiency.

geropl commented 1 year ago

Looking at this a bit more holistically:

So while I think a option on "type: Bot" (default: false) make sense on it's own, we might want to look beyond that to find sth that is stable long-term.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.