gitpod-io / gitpod

The developer platform for on-demand cloud development environments to create software faster and more securely.
https://www.gitpod.io
GNU Affero General Public License v3.0
12.82k stars 1.23k forks source link

Improve the full-page loading indicator #17044

Closed gtsiolis closed 1 year ago

gtsiolis commented 1 year ago

Problem to solve

Back in https://github.com/gitpod-io/gitpod/issues/16803 and https://github.com/gitpod-io/gitpod/pull/16984, a full-page loading indicator was added while loading the dashboard.

Although, this significantly improves the dashboard by not showing a blank white page on load, there's room to improve this page and also avoid confusing users. From https://github.com/gitpod-io/gitpod/pull/16984#discussion_r1145890305:

@gtsiolis: Re-using the bouncing logo could frustrate or confuse users as they usually to see that loading state (bouncing logo) a lot while opening workspaces.

The current state also lacks a loading indication, as the logo remains still, which could confuse users even more as the layout resembles the error page, besides the workspace start page.

Full-page loading Error Start
Screenshot 2023-03-27 at 12 55 08 Screenshot 2023-03-27 at 12 55 15 Screenshot 2023-03-27 at 13 01 52

Proposal

Replace the current full-page loading in indicator with the (animated) spinner animation.

BEFORE AFTER
Screenshot 2023-03-23 at 11 20 36 224318369-368eaa86-4bc1-4bfa-a18b-5cab5f3f775d
himanshu1221 commented 1 year ago

Can I give it a try @gtsiolis?

gtsiolis commented 1 year ago

Sure, @himanshu1221! 🏓

vedant-jain03 commented 1 year ago

@himanshu1221 In case you are not working on this issue, please let me know, I would love to work on this!

himanshu1221 commented 1 year ago

@himanshu1221 In case you are not working on this issue, please let me know, I would love to work on this!

Yes @vedant-jain03 i am still trying

RayAsh37 commented 1 year ago

to sum-up, the current loading page content should be entirely replaced by just a plain Spinner. am I right @gtsiolis ?

gtsiolis commented 1 year ago

Hey @RayAsh37! Chatted with the team about this internally and decided we're going to keep the current version for now. Thanks for hanging here, let me close this for now. 📕