search

gitpod-io / gitpod

The developer platform for on-demand cloud development environments to create software faster and more securely.
https://www.gitpod.io
GNU Affero General Public License v3.0
12.97k stars 1.24k forks source link

Save Color Theme as Light #787

Closed redrockzee closed 4 years ago

redrockzee commented 5 years ago

Describe the bug

Change Color Theme to Light does not save anywhere that can be checked into Git. So, Gitpod always reverts to the default dark theme.

To Reproduce

  1. Open File -> Settings -> Change Color Theme
  2. Select Light Theme
  3. Stop and open a new Gitpod instance
  4. Theme is dark again

Expected behavior

I would expect some way to set the default theme even when a new docker instance is started. I tried using the the Theia settings in package.json referenced by this PR, but it did not work.

https://github.com/eclipse-theia/theia/pull/2442

akosyakov commented 5 years ago

Currently theme is preserver only for the same origin, for each new workspace the default (dark) theme is used. We can add a preference to allow a user configure the default them it in user settings. @svenefftinge sounds good? pleas open a feature request in Theia repo.

JesterOrNot commented 4 years ago

Hey have we considered localstorage for this?

JesterOrNot commented 4 years ago

or better yet something in the .gitpod.yml file maybe a section for it

theming:
    - editor-theme: light

that way it also paves the way for future customization!

svenefftinge commented 4 years ago

Theming is a user-specific setting not workspace specific so putting it into the .gitpod.yml would be the wrong place. But I have good news, as we are going to roll this out next week.

JesterOrNot commented 4 years ago

Awesome!

laike9m commented 4 years ago

Hi Sven, may I ask what is the correct way to configure (and share) theme as of now?