gitpod-io / gitpod

The developer platform for on-demand cloud development environments to create software faster and more securely.
https://www.gitpod.io
GNU Affero General Public License v3.0
12.7k stars 1.21k forks source link

Design improvements for the new "New Workspace" modal #8088

Closed jankeromnes closed 1 year ago

jankeromnes commented 2 years ago

Suggested improvements

Based on discussion (internal)

  1. Recover behavior to show recents by default (#8380 ✅)

    • Autopopulate results even when input is empty
    • Tweak result ranking to show recents first
    • Remove current help text
    • Set placeholder = “Paste repository URL or type for suggestions”
  2. Result rendering - visually break down repo URLs into multiple lines

    For results based on existing repositories:

    repo-name <git provider>/<org-or-user-or gitlab-group...> (wrapped?) issue-pr-commit-context (optional?)

    For pasted URLS:

    https://pasted-url/...

  3. Modal UX and styles

    • grey background [1].
    • text input consistency: focus/active state colors
    • bold grey vs soft grey selection
    • tweak modal size (may affect all modals - ok)
    • (lower priority - only if time permits) results found at bottom vs. infinite scroll
    • make sure the scrolling area is clear to the user[1]
  4. (Optional) Results visual differentiation

    • history / recent worspaces
    • own repos
    • examples

Current design

Screenshot 2022-02-08 at 12 10 53 Screenshot 2022-02-08 at 12 13 43 Screenshot 2022-02-08 at 12 12 49 Screenshot 2022-02-08 at 12 14 10
jankeromnes commented 2 years ago

We could also bake in this requirement here:

  • [ ] A larger, cleaner user interface

I think we could even make all modals a bit larger, as suggested (internal) by @geropl:

:thread: While having a look at https://github.com/gitpod-io/gitpod/pull/7715 in noticed something that is tickling me for a while now: Can we make our modals a tad bigger? :upside_down_face:

IMO that would help with:

  • settings focus on the modal
  • auto-wrap of context URLs in various places
  • the "cramped" feeling the modal gives
jankeromnes commented 2 years ago

Cool suggestion from @felladrin on Slack (internal):

In the modal's current empty state, the text "Example repositories" could be a link, which either:

Current empty state Proposal 🅰️ (pre-fill) Proposal 🅱️ (link)
Screenshot 2022-02-09 at 17 05 33 Screenshot 2022-02-09 at 17 31 38 Screenshot 2022-02-09 at 17 34 50
felladrin commented 2 years ago

Another suggestion: disable spell checking, autocomplete, and autocorrect on the input field, by adding these attributes to the html input tag: autocomplete="off" autocorrect="off" autocapitalize="off" spellcheck="false"

jldec commented 2 years ago

@jankeromnes - I have updated the description above based on our discussion. @gtsiolis - If you have a figma design which which matches the new outlined changes, please add image inline above.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

gtsiolis commented 1 year ago

Closing this as the next iteration for improving the new workspace modal has been added in https://github.com/gitpod-io/gitpod/pull/15389. Cc @svenefftinge

There are still lots of improvements we could make like structure and visual improvements, but I'll close this as this issue lacks a clear problem statement and proposal.