Allow the app to be installed as a PWA

gitpod-io / openvscode-server

Run upstream VS Code on a remote machine with access through a modern web browser from any device, anywhere.

https://www.gitpod.io/

MIT License

4.94k stars 428 forks source link

Allow the app to be installed as a PWA #120

Open JeDaYoshi opened 2 years ago

JeDaYoshi commented 2 years ago

The app already includes a manifest.json - but it's lacking some details. Most notably:

It has no Service Worker included, so Chrome etc. says "no"
the app lacks any proper icons (although this also applies to favicons) - maybe some should be added :)

bigint commented 2 years ago

+1 love to see this, code-server has this great option, but I love Gitpod 😄

tlockney commented 2 years ago

It does allow you to at least create the app on iPadOS in Safari, but it uses the redirect URL without the token, so when you try to open it, you get a "Forbidden" message.

filiptronicek commented 2 years ago

Please see https://github.com/microsoft/vscode/issues/135553 for tracking progress on this issue.

hanneshayashi commented 2 years ago

Seems like this has been implemented now upstream in https://github.com/microsoft/vscode/issues/135553.

filiptronicek commented 2 years ago

Seems like this has been implemented now upstream in microsoft#135553.

Yes indeed, thanks for noticing. Before we close this, I want to wait until we ship insiders today, I have a feeling this will not work right away since this mainly affects vscode.dev.

jrderuiter commented 1 year ago

Any updates on this? (Would love to have this feature to address keyboard shortcuts etc.)

Nishchit14 commented 1 year ago

This is a very needy feature (also easy to implement), I don't know why it's taking a year-long time. I am coming from a codespace and the experience is not matching due to PWA here in the GitPod.

anyway this helped me for now https://github.com/gitpod-io/gitpod/issues/1445#issuecomment-1028706854

bbigras commented 10 months ago

Is this still relevant?