search

gitpod-io / openvscode-server

Run upstream VS Code on a remote machine with access through a modern web browser from any device, anywhere.
https://www.gitpod.io/
MIT License
4.99k stars 431 forks source link

Use ports order from supervisor #444

Closed mustard-mh closed 1 year ago

mustard-mh commented 1 year ago

Ports order is random in vscode now, because we don't clean up map in portViewProvider.ts, this PR will make order respect to supervisor's responding

How to test

Check with https://github.com/gitpod-io/gitpod/pull/13788

akosyakov commented 1 year ago

Is not Map in JS have insertion order? 🤔

mustard-mh commented 1 year ago

Is not Map in JS have insertion order? 🤔

@akosyakov According to its define (just know it), it will. But inside portViewProvider.ts we don't clear map and recreate it.

Found it because order not align to response's order in preview env

So it makes sense to keep code inside portViewProvider.ts only? and remove extension.ts's changes?

akosyakov commented 1 year ago

@akosyakov According to its define (just know it), it will. But inside portViewProvider.ts we don't clear map and recreate it.

ok, make sense 👍