search

gitpod-io / openvscode-server

Run upstream VS Code on a remote machine with access through a modern web browser from any device, anywhere.
https://www.gitpod.io/
MIT License
4.99k stars 431 forks source link

Remove usage of `.public` #458

Closed filiptronicek closed 1 year ago

filiptronicek commented 1 year ago

Adhere to changes made in https://github.com/microsoft/vscode/commit/d56f8a8ddee825a784b8964cae91ce6e60b6b844

How to test

  1. Open a repository with ports config in the preview environment: https://ft-test-ports-public.preview.gitpod-dev.com/workspaces
  2. play around with ports' visibility. Make sure toggling and displaying correctly reflects the port's public/private state.
jeanp413 commented 1 year ago

@mustard-mh could you review it :pray:

mustard-mh commented 1 year ago

Could you add How to Test section 🙏 ? We need to test if it won't break ports' operations. @filiptronicek

filiptronicek commented 1 year ago

@mustard-mh added ✅ 🙏