Clean up analytics - Githubissues

gitpod-io / openvscode-server

Run upstream VS Code on a remote machine with access through a modern web browser from any device, anywhere.

https://www.gitpod.io/

MIT License

4.84k stars 423 forks source link

Closed jeanp413 closed 10 months ago

jeanp413 commented 1 year ago

jeanp413 commented 10 months ago

@mustard-mh could you test this :pray:

mustard-mh commented 10 months ago

Just notice this PR, going to rebase and force push ✅

mustard-mh commented 10 months ago

❌ Will go test it in Gitpod and preview env, since comments above are all not blocking

jeanp413 commented 10 months ago

@mustard-mh it works now :tada:

mustard-mh commented 10 months ago

session id will be redacted, so we need to make it trusted? here? https://github.com/gitpod-io/openvscode-server/blob/a23e67151652a5a63a2b6aadbc24b8d4455faee0/src/vs/gitpod/common/insightsHelper.ts#L96
workspace id needs to be redacted, but it should be done on gitpod server side

jeanp413 commented 10 months ago

session id will be redacted, so we need to make it trusted? here?

I checked and the request is done with the original value, maybe it's just something visual from segment UI, if not we could rename the field