search

gitpod-io / openvscode-server

Run upstream VS Code on a remote machine with access through a modern web browser from any device, anywhere.
https://www.gitpod.io/
MIT License
4.84k stars 423 forks source link

Docker Image and VSCode secretsStorage persistence on browser refresh. #544

Open bd82 opened 5 months ago

bd82 commented 5 months ago

It is not quite a bug, however there seems to be something missing in the Open VSCode Server Getting Started docker image.

Issue Description

Basically a browser refresh seems to cause all secrets stored with context.secrets.store to be lost. This does not reproduce on productive gitpod (or codespaces). So I am guessing, something may be missing in the docker container.

Why I care

I have (apparently) exactly the same problem in a productive fork of Open VSCode Server. So I am assuming this is a solved and known container configuration issue and that solving it for the OVSCS docker image would demonstrate how it could be solved in my specific flow as well.

Reproducing Minimal Extension (with step by step)

Thanks in advance.

bd82 commented 5 months ago

Hmm, looks like this is implemented new code in gitpod branch using localStorage