search

gitpod-io / openvscode-server

Run upstream VS Code on a remote machine with access through a modern web browser from any device, anywhere.
https://www.gitpod.io/
MIT License
4.84k stars 423 forks source link

Could not load vsce-sign module Cannot find module '@vscode/vsce-sign' #556

Closed ghthor closed 3 months ago

ghthor commented 3 months ago

Does this issue occur when all extensions are disabled?: n/a

Steps to Reproduce:

  1. Run openvscode-server
  2. Install an extension
  3. See Logs about Extension verification failed
  4. Extension is never activated, Runtime Status always shows 'not yet activated'
[14:48:41] Could not load vsce-sign module Cannot find module '@vscode/vsce-sign'
Require stack:
- /nix/store/0588dnrh09i97vz6n6b903dx2kl09r2a-openvscode-server-1.87.1/out/server-main.js
[14:48:41] Extension signature verification is not done: mkhl.direnv
[14:48:41] Extracted extension to file:///home/ghthor/.openvscode-server/extensions/mkhl.direnv-0.17.0-universal: mkhl.direnv

I realize this could be a result of the nixpkgs build and not an upstream thing, but posting here just in case.

ghthor commented 3 months ago

I confirmed that extensions are getting installed AND activated on v1.84.0 and there are not logs about failures to load the vsce-sign module

[15:14:53] Getting Manifest... pinage404.nix-extension-pack
[15:14:54] Installing extension: pinage404.nix-extension-pack
[15:14:54] Getting Manifest... mkhl.direnv
[15:14:55] Getting Manifest... jnoortheen.nix-ide
[15:14:56] Getting Manifest... arrterian.nix-env-selector
[15:14:57] Installing extension: mkhl.direnv pinage404.nix-extension-pack
[15:14:57] Installing extension: jnoortheen.nix-ide pinage404.nix-extension-pack
[15:14:57] Installing extension: arrterian.nix-env-selector pinage404.nix-extension-pack
[15:14:59] Extension signature verification is not done: mkhl.direnv
[15:14:59] Extracted extension to file:///home/ghthor/.openvscode-server/extensions/mkhl.direnv-0.17.0-universal: mkhl.direnv
[15:14:59] Renamed to /home/ghthor/.openvscode-server/extensions/mkhl.direnv-0.17.0-universal
[15:14:59] Extracting extension completed. mkhl.direnv
[15:15:00] Extension signature verification is not done: jnoortheen.nix-ide
[15:15:00] Extracted extension to file:///home/ghthor/.openvscode-server/extensions/jnoortheen.nix-ide-0.3.1-universal: jnoortheen.nix-ide
[15:15:00] Renamed to /home/ghthor/.openvscode-server/extensions/jnoortheen.nix-ide-0.3.1-universal
[15:15:00] Extracting extension completed. jnoortheen.nix-ide
[15:15:02] Extension signature verification is not done: arrterian.nix-env-selector
[15:15:03] Extracted extension to file:///home/ghthor/.openvscode-server/extensions/arrterian.nix-env-selector-1.0.11-universal: arrterian.nix-env-selector
[15:15:03] Renamed to /home/ghthor/.openvscode-server/extensions/arrterian.nix-env-selector-1.0.11-universal
[15:15:03] Extracting extension completed. arrterian.nix-env-selector
[15:15:05] Extension signature verification is not done: pinage404.nix-extension-pack
[15:15:05] Extracted extension to file:///home/ghthor/.openvscode-server/extensions/pinage404.nix-extension-pack-3.0.0-universal: pinage404.nix-extension-pack
[15:15:05] Renamed to /home/ghthor/.openvscode-server/extensions/pinage404.nix-extension-pack-3.0.0-universal
[15:15:05] Extracting extension completed. pinage404.nix-extension-pack
[15:15:05] Extension installed successfully: mkhl.direnv
[15:15:05] Extension installed successfully: jnoortheen.nix-ide
[15:15:05] Extension installed successfully: arrterian.nix-env-selector
[15:15:05] Extension installed successfully: pinage404.nix-extension-pack
❯ file /home/ghthor/.nix-profile/bin/openvscode-server
/home/ghthor/.nix-profile/bin/openvscode-server: symbolic link to /nix/store/d214dm7a5mc608l7r6vxlhvgal9i4d16-openvscode-server-1.84.0/bin/openvscode-server

❯ openvscode-server --version
1.84.0
Unknown commit
x64
ghthor commented 3 months ago

In version v1.85.1 I don't see any of the error logs when installing extensions, but still none of the extensions ever activate

[15:22:43] Getting Manifest... pinage404.nix-extension-pack
[15:22:44] Installing extension: pinage404.nix-extension-pack
[15:22:44] Getting Manifest... mkhl.direnv
[15:22:45] Getting Manifest... jnoortheen.nix-ide
[15:22:46] Getting Manifest... arrterian.nix-env-selector
[15:22:47] Installing extension: mkhl.direnv pinage404.nix-extension-pack
[15:22:47] Installing extension: jnoortheen.nix-ide pinage404.nix-extension-pack
[15:22:47] Installing extension: arrterian.nix-env-selector pinage404.nix-extension-pack
[15:22:48] Extension signature verification is not done: mkhl.direnv
[15:22:48] Extension signature verification is not done: arrterian.nix-env-selector
[15:22:48] Extension signature verification is not done: jnoortheen.nix-ide
[15:22:48] Extracted extension to file:///home/ghthor/.openvscode-server/extensions/mkhl.direnv-0.17.0-universal: mkhl.direnv
[15:22:48] Renamed to /home/ghthor/.openvscode-server/extensions/mkhl.direnv-0.17.0-universal
[15:22:48] Extracting extension completed. mkhl.direnv
[15:22:48] Extracted extension to file:///home/ghthor/.openvscode-server/extensions/jnoortheen.nix-ide-0.3.1-universal: jnoortheen.nix-ide
[15:22:48] Renamed to /home/ghthor/.openvscode-server/extensions/jnoortheen.nix-ide-0.3.1-universal
[15:22:48] Extracting extension completed. jnoortheen.nix-ide
[15:22:48] Extracted extension to file:///home/ghthor/.openvscode-server/extensions/arrterian.nix-env-selector-1.0.11-universal: arrterian.nix-env-selector
[15:22:48] Renamed to /home/ghthor/.openvscode-server/extensions/arrterian.nix-env-selector-1.0.11-universal
[15:22:48] Extracting extension completed. arrterian.nix-env-selector
[15:22:49] Extension signature verification is not done: pinage404.nix-extension-pack
[15:22:49] Extracted extension to file:///home/ghthor/.openvscode-server/extensions/pinage404.nix-extension-pack-3.0.0-universal: pinage404.nix-extension-pack
[15:22:49] Renamed to /home/ghthor/.openvscode-server/extensions/pinage404.nix-extension-pack-3.0.0-universal
[15:22:49] Extracting extension completed. pinage404.nix-extension-pack
[15:22:49] Extension installed successfully: mkhl.direnv
[15:22:49] Extension installed successfully: jnoortheen.nix-ide
[15:22:49] Extension installed successfully: arrterian.nix-env-selector
[15:22:49] Extension installed successfully: pinage404.nix-extension-pack
[15:23:05] Getting Manifest... pinage404.nix-extension-pack
[15:23:06] Installing extension: pinage404.nix-extension-pack
[15:23:06] Extension installed successfully: pinage404.nix-extension-pack
❯ file /home/ghthor/.nix-profile/bin/openvscode-server
/home/ghthor/.nix-profile/bin/openvscode-server: symbolic link to /nix/store/yjl6jjh775h8i9apmdd87624n7fxs3sg-openvscode-server-1.85.1/bin/openvscode-server

❯ openvscode-server --version
1.85.1
Unknown commit
x64
filiptronicek commented 3 months ago

@jeanp413 did ms change something recently in forcing signature verification for extensions?

ghthor commented 3 months ago

This turned out to be a red herring. The extensions were not loading because I needed to clear my browser cache, the existing cached files were causing issues.