gitpod-io / retired-gatsby-website

Gitpod website and documentation
https://www.gitpod.io/
MIT License
68 stars 75 forks source link

Moving GitHub link to navigation bar #912

Closed chrifro closed 3 years ago

chrifro commented 3 years ago

Follow-up issue for #882

Problem

Proposal

before after
Bildschirmfoto 2020-12-17 um 14 49 07 Bildschirmfoto 2020-12-17 um 14 52 21
gtsiolis commented 3 years ago

Adding some relevant feedback from the previous iteration in https://github.com/gitpod-io/website/issues/882#issuecomment-740610624:

Do we want to add this near the logo?

If we add this near the logo we'll have to figure out how this adapts on small viewports (mobile).

chrifro commented 3 years ago

If we add this near the logo we'll have to figure out how this adapts on small viewports (mobile).

As Johannes suggested, I'd move the log in button to the drop down menu (see here ) and keep the GitHub link. On tablet there should be enough space for both items

Bildschirmfoto 2020-12-17 um 15 11 00
chrifro commented 3 years ago

What do you think @JohannesLandgraf @svenefftinge? Shall we keep the layout the way it is or implement this suggestion?

JohannesLandgraf commented 3 years ago

Let’s keep it for now, I don’t think it makes sense to add such (small) improvements to the website before the redesign