search

gitpod-io / retired-gatsby-website

Gitpod website and documentation
https://www.gitpod.io/
MIT License
68 stars 75 forks source link

fix headlines order for better accessibility and seo. #917

Closed nisarhassan12 closed 3 years ago

nisarhassan12 commented 3 years ago

Addresses the following from #842

image

Why this is important:

According to https://www.w3.org/WAI/tutorials/page-structure/headings/

image

nisarhassan12 commented 3 years ago

I have corrected the order of the headings for all the pages of the site including the docs. On the blog, the heading order still needs to be corrected. @ChristinFrohne @JohannesLandgraf Can I change the order of the headings in the blog posts as well? Or do I have to check with the authors of the individual blog posts first? Thanks

chrifro commented 3 years ago

Thanks @nisarhassan12 Looks good. It's fine if you change the headline style without asking the author of each blog post. Your changes won't influence the content, so it's fine.

nisarhassan12 commented 3 years ago

@ChristinFrohne I have made the changes to the blog posts as well. Please have a look again when you'll have time. Thanks

nisarhassan12 commented 3 years ago

Thanks, @ChristinFrohne for the review. I'll merge this after doing a final self-review to see if there aren't any pages that are leftout.