Closed jankeromnes closed 3 years ago
Thanks for adding this @jankeromnes!
issue: This will not behave well on the /docs
, right?
@gtsiolis You mean this?
Yes @jankeromnes! If you want to add this as is, let's also change the margin below to 4rem
to avoid introducing the overflow. WDYT?
@gtsiolis Great suggestion! Many thanks, looks indeed better with 4rem
:
A potential follow-up that was suggested: Removing the "Blog" top-level menu link & reverting back to 5rem
margins.
(I'm personally a bit hesitant on this, since the Blog seems important to me, so I'll leave this change to a potential follow-up PR 😇 🚀)
Seems to look good on all relevant screen sizes:
Desktop
iPad (landsape)
iPhone Plus (portrait)