add announcement banner that we are hiring.

gitpod-io / retired-gatsby-website

Gitpod website and documentation

https://www.gitpod.io/

MIT License

68 stars 75 forks source link

add announcement banner that we are hiring. #972

Closed nisarhassan12 closed 3 years ago

nisarhassan12 commented 3 years ago

Fixes gitpod-io/website#967

This is how it looks:

JohannesLandgraf commented 3 years ago

Thanks @nisarhassan12! Seems to work well. However it is way too invasive and prominent. The banner should probably be at most half the size and the font size also respectively smaller. There is also no need to use bold font here. To be a bit more colloquial I would change the text to: "We're hiring".

nisarhassan12 commented 3 years ago

I have made the requested changes.

JohannesLandgraf commented 3 years ago

Thanks @nisarhassan12!

The button to close the banner is not visible anymore
We should resize the opening hover button. font-size:1.4rem / margin-left: 1.5rem /
Change the text to "We're hiring!"
There are currently 8 openings not 5 (maybe you should rebase the PR; but if you tested your logic and it works then fine for me)

Such as:

I reconsidered banner height is great! If you fixed the three things above feel free to merge on your own!