gitpod-io / retired-gatsby-website

Gitpod website and documentation
https://www.gitpod.io/
MIT License
68 stars 75 forks source link

Job opening banner isn't visible in Chrome #977

Closed chrifro closed 3 years ago

chrifro commented 3 years ago

Problem On Chrome: The banner is only blinking up very shortly and is then closed automatically. On Safari: works fine On Firefox: works fine

Additional Feedback

Could you look into it @nisarhassan12 ?

nisarhassan12 commented 3 years ago

Thanks, @ChristinFrohne for reporting this. Although I was not able to reproduce this on Chrome I have attempted a fix in https://github.com/gitpod-io/website/pull/980 Please have a look at the preview you'll hopefully not see the issue there.

image

we can remove the closing icon. As the banner isn't fixed while scrolling, it doesn't take much space and can be visible at all time.

Maybe it's just me who thinks like this but I would say it is good to keep that close button on the banner which permanently removes it forever. https://www.pulumi.com/ does it similarly. I think one might not call the Banner an ad but it sort of slightly falls into the category off not being relevant to the core contents just like Ads. I think it is better to give users the ability to get rid of it if they want to? I'm not too sure. What do you say? Thanks

chrifro commented 3 years ago

@nisarhassan12 Currently, the CTA to close the banner is more prominent than the link to the job openings. I'm ok with keeping a closing option, but it should be less prominent.

Could you:

Mockup:

Bildschirmfoto 2021-02-01 um 14 30 37