Closed gtsiolis closed 3 years ago
Thanks @gtsiolis 🙇♂️ Both Dark and Light are fine for me - feel free to chose what you like best. @nisarhassan12 once George is done pls take over
Thanks @gtsiolis. I totally agree with your suggestions. I'd prefer the dark version. For context, there is already a pending PR for improvements #984
I will fix this in #984
Thanks @nisarhassan12! Let's go with the dark one that @ChristinFrohne suggested in https://github.com/gitpod-io/website/issues/992#issuecomment-772529736. Let me know if you need help with the specs (colors, spacing, icons). 🏀
Thanks. @gtsiolis I have made the changes in https://github.com/gitpod-io/website/pull/984. Please review that. For now I have spaced things by estimate please suggest the spacing values if they don't look good to you. For the icon for now I'm using →
if that does not look good then please provide the icon. Thanks.
I'm closing this as #984 got merged.
Problem
The banner added in https://github.com/gitpod-io/website/pull/972 comes with some design color contrast and alignment issues. /cc @nisarhassan12 @JohannesLandgraf
Color Contrast
Text: Currently, the broadcast message for the hiring is failing to pass color contrast ratio tests for WCAG 2.0 guidelines.
Emojis: Besides that, the emojis used contain colors that make them also fail for contrast ratio.
Alignment
Both text labels and the close button are using differenst spacing which makes the buttons and text labels look misaligned.
Proposal
Although a) we probably don't want to use a completely different design language compared to the rest of the website an b) such issues will probably be resolved after the redesign, let's try to make this more accessible for now.