gitpod-samples / Gitpod-Raycast-Extension

Raycast Extension for Gitpod
MIT License
15 stars 6 forks source link

Use preference value for Gitpod endpoint everywhere #39

Closed mads-hartmann closed 1 year ago

mads-hartmann commented 1 year ago

Following up on https://github.com/raycast/extensions/pull/5457 - the changes are different here as the code-bases have diverged, but the intention is the same. Most of the work was already done in this repository, so I just grep'ed for the remaining hardcoded references to gitpod.io and changed them to use the preference value instead. ☺️

I did some very basic testing of this:

npm run build # Just to check that I didn't break the build
npm run dev   # To install the extension
# Change the preference value to our Gitpod-internal dogfooding endpoint
# Opened a workspace to ensure it did indeed use endpoint (it did)
Palanikannan1437 commented 1 year ago

LGTM 🍊, thanks for fixing this for the remaining references πŸš€

Especially for taking out the time for making the PR again for this repository πŸ™ˆπŸ§‘