search

gitpoint / git-point

GitHub in your pocket :iphone:
https://gitpoint.co/
MIT License
4.72k stars 790 forks source link

Add Greenkeeper #321

Open housseindjirdeh opened 7 years ago

housseindjirdeh commented 7 years ago

As @andrewda mentioned, might be worthwhile to explore managing dependency updates with Greenkeeper

CC @lex111

chinesedfan commented 6 years ago

@housseindjirdeh I want to play with it. If you see a request from me/greenkeeper, please approve.

housseindjirdeh commented 6 years ago

Just approved ✅

So sorry for not doing it sooner, completely missed the email 😞

machour commented 6 years ago

Assigned @chinesedfan as he wants to tinker around with Greenkeeper. Really curious to see what will come up from this!

chinesedfan commented 6 years ago

Thanks @housseindjirdeh. I am afraid that only you can install Greenkeeper because you are the owner.

I already tested it in my forked git-point repository. Greenkeeper has created the initial PR to update all dependencies to the latest.

Of course, the CI is failed, so we need to determinate dependencies that we really want to update. I suggest to limit the scope to RN related first. What do you think about it? @housseindjirdeh @machour

machour commented 6 years ago

Not sure why the initial PR failed, it seems that babel totally missbihaved there.

It also seems that Greenkeeper updated packages with BC breaking releases (https://github.com/chinesedfan/git-point/pull/2/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2L97) Is there a way to prevent that?

I think that without having a decent coverage, and detox tests, it will be hard to really rely on Greenkeper..

chinesedfan commented 6 years ago

I think Greenkeeper always tries to update dependencies to the latest, even for BC releases. If don't like it, we can close its PR then nothing happens. If felt bothered too much, we can add some dependencies to Greenkeeper ignore list.

I think that without having a decent coverage, and detox tests, it will be hard to really rely on Greenkeper.

Right. We can not rely on Greenkeeper completely. But it can remind us for new releases.