search

gitpoint / git-point

GitHub in your pocket :iphone:
https://gitpoint.co/
MIT License
4.72k stars 787 forks source link

Add into F-Droid #735

Open KOLANICH opened 6 years ago

KOLANICH commented 6 years ago

Could you add your app into F-droid?

alejandronanez commented 6 years ago

Hey @KOLANICH!

Sorry, but how can we do that? I'd be happy to help!

KOLANICH commented 6 years ago

You need to create a PR with metadata into https://gitlab.com/fdroid/fdroiddata/ More info

alejandronanez commented 6 years ago

I’ll do it this week then. Thanks @kolanich!

housseindjirdeh commented 6 years ago

Thanks @alejandronanez <3

And thank you @KOLANICH - if you think it will be useful to have in F-droid, we'll definitely get a PR up 🙌

ghost commented 6 years ago

Any news on this?

machour commented 6 years ago

Hi @Lionirdeadman, from what I understand in the include policy we are not eligible because we're using react-native-device-info which includes google-play-services :-/

ghost commented 6 years ago

Ah.. I see.. are there any plans to change this or should we expect Gitpoint to never be in F-droid?

If we shouldn't expect it to be in F-droid in the future, I think we can close this issue for now.

KOLANICH commented 6 years ago

Could MicroG replace all the things needed?

ghost commented 6 years ago

MicroG is system-level software, it doesn't change how the application is built so no.

The application would (probably) work fine with MicroG but that is completely irrelevant to F-droid inclusion.

KOLANICH commented 6 years ago

The application would (probably) work fine with MicroG but that is completely irrelevant to F-droid inclusion.

As I understand, an app using GSF is forbidden to inclusion into f-droid because GSF is a proprietary near-monopoly (in the sense "nearly everyone have to use that proprietary app controlled entirely by Google (and the ones who control Google) and nearly every dev relies on it and of a phone lacks it most of consumers won't buy it") and the project maintainers wanna discourage usage and promotion of that monopoly.

MicroG is free software, it is included into f-droid and in fact f-droid encourages replacing gsf with it, and in the policy it is written

(either using microg or removing non-free deps completely).

ghost commented 6 years ago

I didn't know there was a way to replace Google libraries in apps using microG. My understanding was that they simply responded to those proprietary libraries. I guess I was wrong though.

Then maybe it's possible to replace them.

chinesedfan commented 6 years ago

Accidentally, I found it had been added(https://apt.izzysoft.de/fdroid/index/apk/com.gitpoint), which was mentioned in #204. Is it the same thing?

ghost commented 6 years ago

No, it's not.

Izzy's repository only takes APKs from Github releases. He doesn't do anything to them.

The official F-droid repository requires all non-free code to be removed (can be done through a flavour) and they build the apk from source.

IzzySoft commented 5 years ago

@chinesedfan so what is the status here? Appbrain's library scanner reports Firebase and GCM – both are show-stoppers for F-Droid. Is there a build flavor that comes without those?

chinesedfan commented 5 years ago

@IzzySoft Sorry not. I contacted with @housseindjirdeh to learn how to publish new release, but he was busy these days. Once there were some progresses, I will update here. And at the same time, would you please send a PR to remove Firebase and GCM? It may not be merged to master, but at least I can use it to build F-Droid specified version.

IzzySoft commented 5 years ago

Thanks, @Chandrasekar-G! And sorry, I'm no Android dev, so I cannot make that PR. And what you're suggesting comes close to another possibility: you could use "build flavors" to provide a "fully floss" flavor for F-Droid to use – and another one for e.g. Playstore.

KOLANICH commented 5 years ago

and another one for e.g. Playstore.

IMHO - tracking iss unacceptable even in completely proprietary apps.

IzzySoft commented 3 years ago

We had a request open at F-Droid which I'll now have to close, unfortunately, as the dependencies are still there. Going by the permissions, it's caused by using FCM and most likely dragged in via

apply from: "../../node_modules/react-native-code-push/android/codepush.gradle"

So should you one day have a foss build flavor, be welcome to reach out to us to either revive that RFP or open a new one.

PS, to clarify again above issue: this is not about GApps vs microG being available on the device. It's about those proprietary libraries included with your app. Unfortunately, there's no FOSS drop-in-replacement for FCM available yet. But there are some push alternatives if you want to have a look (that list is far from being complete, so hints for complementations are welcome, too).