search

gitpoint / git-point

GitHub in your pocket :iphone:
https://gitpoint.co/
MIT License
4.72k stars 790 forks source link

Use Git Data API for files #889

Open Rexogamer opened 4 years ago

Rexogamer commented 4 years ago

This would allow us to get files up to 100mb in size.

chinesedfan commented 4 years ago

Thanks for your suggestion. But how do users view such large files? It is hard to navigate to certain lines or do anything else.

Rexogamer commented 4 years ago

...I don’t really see what that has to do with this...

Currently, we can only get file that are up to 1MB in size using the GitHub API, but if we used this API, we could get bigger files. How is it hard to navigate? Please elaborate.

chinesedfan commented 4 years ago

I mean files that are larger than 1mb must contain thousands or more lines of codes. So even if we load them, users can't read them.

Can you provide a large file example? Like the file path in a repository. And what do you expect for which screen? The file list or the file detail?

Rexogamer commented 4 years ago

This is simply an API change. No UI changes were requested in this issue, if that was what you were asking.

When I try to load this file,, I get the following error: 794A202B-D2B8-47AD-9B18-81BC13E479F0

Rexogamer commented 4 years ago

When you say “users can’t read them”, are you suggesting the client would be laggy, or about screen size, or something else?

chinesedfan commented 4 years ago

When you say “users can’t read them”, are you suggesting the client would be laggy, or about screen size, or something else?

Yes. I admit that the current behavior is not the best one. If we updated the API without UI enhancements to handle large files, users may face new problems.

Rexogamer commented 4 years ago

We don’t and won’t know what those issues are until we try the API change.